Skip to content

fix(install): add null check for package feed entries to prevent errors on empty or malformed XML #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(install): add null check for package feed entries to prevent errors on empty or malformed XML #710

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 22 additions & 18 deletions install.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,24 +515,28 @@ if (-not $noGui.IsPresent) {
$ns.AddNamespace("m", "http://schemas.microsoft.com/ado/2007/08/dataservices/metadata")

# Extract package information from the XML
$vm_packages.feed.entry | ForEach-Object {
$isLatestVersion = $_.SelectSingleNode("m:properties/d:IsLatestVersion", $ns).InnerText
$category = $_.SelectSingleNode("m:properties/d:Tags", $ns).InnerText
# Select only packages that have the latest version, contain a category and the category is not excluded
if (($isLatestVersion -eq "true") -and ($category -ne "") -and ($excludedCategories -notcontains $category)) {
$packageName = $_.properties.Id
$description = $_.properties.Description

# Initialize category as an empty array
if (-not ($packagesByCategory.ContainsKey($category))) {
$packagesByCategory[$category] = @()
}
# Add the PackageName and PackageDesccription to each entry in the array
$packagesByCategory[$category] += [PSCustomObject]@{
PackageName = $packageName
PackageDescription = $description
}
}
if ($vm_packages.feed.entry) {
$vm_packages.feed.entry | ForEach-Object {
$isLatestVersion = $_.SelectSingleNode("m:properties/d:IsLatestVersion", $ns).InnerText
$category = $_.SelectSingleNode("m:properties/d:Tags", $ns).InnerText
# Select only packages that have the latest version, contain a category and the category is not excluded
if (($isLatestVersion -eq "true") -and ($category -ne "") -and ($excludedCategories -notcontains $category)) {
$packageName = $_.properties.Id
$description = $_.properties.Description

# Initialize category as an empty array
if (-not ($packagesByCategory.ContainsKey($category))) {
$packagesByCategory[$category] = @()
}
# Add the PackageName and PackageDesccription to each entry in the array
$packagesByCategory[$category] += [PSCustomObject]@{
PackageName = $packageName
PackageDescription = $description
}
}
}
} else {
Write-Host "No entries found in the package feed XML. The file may be empty or malformed."
}
# Check if there is a next link in the XML and set the API URL to that link if it exists
$nextLink = $vm_packages.SelectSingleNode("//atom:link[@rel='next']/@href", $ns)
Expand Down