Skip to content

[install.sh] Update Test-WebConnection function to check connectivity more robustly #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[install.sh] Update Test-WebConnection function to check connectivity more robustly #731

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions install.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,16 +142,16 @@ $mandatoryChecksPassed = $true
$exit_message = "Installation cannot continue."

################################# Functions that conduct Pre-Install Checks #################################
# Function to test the network stack. Ping/GET requests to the resource to ensure that network stack looks good for installation
# Function to test the network stack. TCP Connect as well as a GET request to the resource ensures that the network stack looks good for installation
function Test-WebConnection {
param (
[string]$url
)

Write-Host "[+] Checking for Internet connectivity ($url)... (mandatory)"

if (-not (Test-Connection $url -Quiet)) {
return "It looks like you cannot ping $url. Check your network settings."
if (-not ((Test-NetConnection $url -Port 443 -ErrorAction SilentlyContinue 3>$null | Select-Object -ExpandProperty TcpTestSucceeded) -eq $True)) {
return "It looks like you cannot connect to $url. Check your network settings."
}

$response = $null
Expand Down