Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RawLazy #605

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add RawLazy #605

wants to merge 4 commits into from

Conversation

MikeZeDev
Copy link
Contributor

@MikeZeDev MikeZeDev commented May 8, 2024

manga-download/hakuneko#6925

Website redirect 2 times on random hosts for chapter content. Doing it the lazy way.

return mangas.map(manga => new Manga(this, provider, manga.pathname, MangaLabelExtractor.call(this, manga)));

} catch (error) {
return [];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific reason why errors are suppressed instead of letting it bubble up?

Copy link
Contributor Author

@MikeZeDev MikeZeDev May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Website dont stop properly and just give error 500.

Hum. It could be a rate limit now that you say it.

Can i use RateLimit for this if i dont know how many page?

Copy link
Contributor Author

@MikeZeDev MikeZeDev May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, in case we go too far, "mes" is not html at all meaning DOMParser.parsefromString will trigger an exception. I guess ill have to the the "going" (yes/no)value from results, but error 500 trigger first.

Target is page 800, 801 got nothing.

Copy link
Contributor Author

@MikeZeDev MikeZeDev May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still cant pass rate limit, damn. Even a 2 seconds delay between request is not enough. Its damn slow already...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ronny1982 I keep getting error 500 after a random number of pages with 3 seconds delay.
Should i just keep that Try-catch?

web/src/engine/websites/RawLazy.ts Outdated Show resolved Hide resolved
web/src/engine/websites/RawLazy.ts Outdated Show resolved Hide resolved
web/src/engine/websites/RawLazy.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants