-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RawLazy #605
base: master
Are you sure you want to change the base?
Add RawLazy #605
Conversation
web/src/engine/websites/RawLazy.ts
Outdated
return mangas.map(manga => new Manga(this, provider, manga.pathname, MangaLabelExtractor.call(this, manga))); | ||
|
||
} catch (error) { | ||
return []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any specific reason why errors are suppressed instead of letting it bubble up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Website dont stop properly and just give error 500.
Hum. It could be a rate limit now that you say it.
Can i use RateLimit for this if i dont know how many page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, in case we go too far, "mes" is not html at all meaning DOMParser.parsefromString
will trigger an exception. I guess ill have to the the "going" (yes/no)value from results, but error 500 trigger first.
Target is page 800, 801 got nothing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still cant pass rate limit, damn. Even a 2 seconds delay between request is not enough. Its damn slow already...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ronny1982 I keep getting error 500 after a random number of pages with 3 seconds delay.
Should i just keep that Try-catch?
manga-download/hakuneko#6925
Website redirect 2 times on random hosts for chapter content. Doing it the lazy way.