test commit #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

maxencerb wants to merge 40 commits into develop from test/erc4626

Contributor

maxencerb commented Feb 10, 2025

No description provided.

maxencerb and others added 8 commits

February 10, 2025 14:36


          test commit

7c5b02a


          wip:erc4626 kandel

84111f4


          fix:kandle seeder tests

ca6c5bd


          test erc4626 kandel + remove shares logic from erc4626 router

be7961c


          cleanup


          restore foundry config

d212f0b


          test morpho kandel + use require reverts in router

d69876f


          remove puller logic + admin token rescue + skip deposit if not vault …

a41f5e4

…found

Solthodox marked this pull request as ready for review

February 25, 2025 08:52


          setVault function for kandel

2370e49

maxencerb commented

View reviewed changes

src/strategies/offer_maker/market_making/kandel/ERC4626Kandel.sol Outdated Show resolved Hide resolved

src/strategies/offer_maker/market_making/kandel/ERC4626KandelSeeder.sol Outdated Show resolved Hide resolved


          make kandel router admin

9a976b7

maxencerb commented

View reviewed changes

src/strategies/routers/integrations/ERC4626Router.sol Outdated Show resolved Hide resolved

maxencerb commented

View reviewed changes

src/strategies/routers/integrations/ERC4626Router.sol Outdated Show resolved Hide resolved

maxencerb commented

View reviewed changes

src/strategies/routers/integrations/ERC4626Router.sol Outdated Show resolved Hide resolved

maxencerb commented

View reviewed changes

src/strategies/routers/integrations/ERC4626Router.sol Outdated Show resolved Hide resolved

maxencerb commented

View reviewed changes

src/strategies/routers/integrations/MorphoVaultRouter.sol Outdated Show resolved Hide resolved

Solthodox added 4 commits

February 28, 2025 11:15


          fixes

2f99fa8


          doc + redeposit + use transferLib

dcf708c


          fix:add missing submodules

dffb583


          fix:add missing submodules

4943db1

Solthodox force-pushed the test/erc4626 branch from 01e3969 to 4943db1 Compare

March 3, 2025 09:32

Solthodox and others added 3 commits

March 3, 2025 10:38


          Update CHANGELOG.md with submodule configuration fixes

f23dc1a


          fix: added 0 vault bugfix + view function (#294)

d049849


          add erc4646 deployment scripts + fix stack too deep

b43b8fc

maxencerb commented

View reviewed changes

Contributor Author

maxencerb left a comment

Create a MorphoKandelSeeder as well, so jsut the basic erc4626kandel with the morphoRouter

src/strategies/offer_maker/market_making/kandel/ERC4626KandelSeeder.sol Outdated Show resolved Hide resolved

src/strategies/routers/integrations/MorphoVaultRouter.sol Outdated Show resolved Hide resolved

Solthodox added 4 commits

March 11, 2025 19:06


          fix:router deployment in erc4626seeder + create morpho seeder

ecda391


          remove unnecesary storage + fix script

d80ac58


          fix:remove unused imports

2c13414


          fix:remove redundant function override

b47bc89

Solthodox and others added 19 commits

March 12, 2025 11:18


          fix:wrong argument in event emission

b3e5f17


          fix:include fees in erc4626 shares valuation

3a997a9


          chore:refactor redundant condition

34e0c91


          chore:add missing event emissions

d4beedc


          feat:check vault asset in {setVaultForToken}

245eccf


          feat: set vault event emission + doc

7baf0f3


          fix:add slippage protection for vault exit

2d9e736


          chore:add warning notes in doc

939bfee


          fix:remove unused import in morpho router

f90f4bc


          fix:remove duplicated comments

af0fa91


          fix:remove unused event

862271c


          fix:morpho rewards receiver

46cea0c


          fix:use forceApprove in erc4626 router


          fix:withdraw rounding issues + code refactor

9c8826d


          fix:confusing doc

221ab02


          fix:revert to old transferLib + OZ credits

a1dc9aa


          feat:minSharesOut param in setVault

3e2c501


          feat:hardode kandel as owner in event emission

7ff06e7


          Merge pull request #295 from mangrovedao/cantina-fixes

Cantina audit fixes

Solthodox closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet