Feat/permit2 makers #82
Conversation
| ApprovalInfo memory approvalInfo; | ||
| uint pulled = router().pull(IERC20(order.olKey.outbound_tkn), owner, amount, true, approvalInfo); | ||
| if (data.usePermit2) { | ||
| approvalInfo.approvalType = ApprovalType.Permit2Approval; | ||
| } | ||
| uint pulled = router().pull(IERC20(order.olKey.outbound_tkn), data.owner, amount, true, approvalInfo); |
There was a problem hiding this comment.
There is something wrong with the current logic. We are only. a partial ApprovalInfo object if we use permit2.
Currently, if we use permit2 with an offer forwarder on pull, this is what the code does :
- pushes successfully
- uses the
ApprovalTransferLib.sollib to pull - Use the
Permit2TransferLib.sollib functiontransferTokenFromWithPermit2that will try to permit our forwarder to pull from the reserve, but our signature is0x0as we didn't pass anything - From now it failed but should transfer tokens to forwarder
The only thing that should differ is permit2.transferFrom(...) instead of token.transferFrom(...) if we use permit2.
The approval should have been given in advance by the reserve right ?
There was a problem hiding this comment.
Did you test it ?
What I remember implementing was that if approvalInfo.spender is 0x0 we directly call permit2.transferFrom which expect the use approve using permit2 in advance.
So here when Jean is only setting approvalType it means that spender and signature will be 0x0 meaning that we will directly call permit2.transferFrom which will succeed if
- The user approve ERC20 -> Permit2
- The user approved the router using Permit2 by using an EOA to
approveor a contract callingpermitwith the user signature
The approval should have been given in advance by the reserve right ?
yes
There was a problem hiding this comment.
Just assumed, should have looked into permit2 before then. The function sig is very mysterious then that's why, I'll try and run it
There was a problem hiding this comment.
Yes the code above assumes the signature has been already given to permit2
This PR proposes to allow strats made with the strat lib (either Direct or Forwarder) to use permit2 approval.
Permit2 based approvals for Direct is not implemented and left to the designer's choice (in order not to impose additional gas cost if the strat does not want to use permit2).