first pass at new editions contract

[campionfellin]

This PR

This PR creates a new extension contract for minting Editions. This is used by the Series Uploader app (and maybe others). Essentially, it's a gas-efficient way to mint a bunch of tokens to yourself (or others).

The major changes from the old contract is that it takes in an instance ID for idempotency rather than a seriesIndex. This is more in-line with moving everything towards instances going forward.

Screenshots (if applicable)

N/A.

Ticket

https://linear.app/manifoldxyz/issue/CON-215/[batch-mint]-new-smart-contract

CR Notes

QA Steps

• [ ]

[github-actions]

LCOV of commit 79b5ac6 during Test! #354

Summary coverage rate:
  lines......: 39.2% (858 of 2186 lines)
  functions..: 43.9% (161 of 367 functions)
  branches...: 30.1% (343 of 1140 branches)

Files changed coverage rate: n/a

[github-actions]

LCOV of commit 367d273 during Test! #321

Summary coverage rate:
  lines......: 37.1% (203 of 547 lines)
  functions..: 31.5% (29 of 92 functions)
  branches...: 30.7% (118 of 384 branches)

Files changed coverage rate: n/a

[donpdang]

Why do we need nonReentrant here ? Curious cause we don't have this in our other contract mint function such as LazyClaims721 contract

[campionfellin]

I believe it's because of the order of the end of the function here...

        uint256[] memory tokenIds = IERC721CreatorCore(creatorCore).mintExtensionBatch(recipient, count);
        _updateIndexRanges(creatorCore, instanceId, tokenIds[0], count);

If the recipient is a smart contract address, and has onERC721Received function that calls back in here, it could continue to loop this function before we call _updateIndexRanges to account for the total minted..

@wwhchung might know more

[donpdang]

Does this work if I want to initialize a series and mint a bunch of tokens to my address only?

[donpdang]

Whats the point of maxSupply if the mint function is gated by the creator only?

[campionfellin]

Hmm.. I think it's helpful when they want say 300 tokens, so you can split into 2 transactions. maxSupply will be 300 and then totalSupply will be 200 after first tx and 300 after the next tx.

But yeah - not sure why we had this in the original contract..

[donpdang]

ah yea make sense for multi transactions due to gas limit

[wwhchung]

Ok, with the v3 changes as discussed, this should be changed.

struct EditionInfo {
uint16 contractVersion;
uint24 totalSupply;
uint24 maxSupply;
string tokenPrefix;
}

mapping(address => mapping(uint256 => EditionInfo)) _editionInfo;

Now, we can store maxSupply, totalSupply and contract version into a single storage slot, further reducing memory usage.

[wwhchung]

Also introduce:
uint256 internal constant MAX_UINT_56 = 0xffffffffffffff;

and ensure instanceId's <= uint56 (for data packing)

[wwhchung]

This is wrong though. you need to call mintExtensionBatch with the count of the first recipient. Also you're double minting for the first recipient.

I'm pretty sure mintExtensionBatch will revert with count 0.

The logic is simpler now isn't it?

uint256[] memory tokenIdResults;
for (uint256 i; i < recipients.length;) {
       if (count == 0) revert InvalidCount();
        count += recipients[i].count;
        if (_totalSupply[creatorCore][instanceId]+count > _maxSupply[creatorCore][instanceId]) revert TooManyRequested();
        tokenIdResults = IERC721CreatorCore(creatorCore).mintExtensionBatch(recipients[i].recipient, recipients[i].count);
        if (i == 0) startIndex = tokenIdResults[0];
        unchecked{++i;}
    }

[campionfellin]

Ok, updated to use this

[wwhchung]

hold on, I'm making some changes

[wwhchung]

thought of some stuff

[wwhchung]

as per above, change to (also no need to return anything anymore) (also argument ordering to be consistent with other extensions, creatorCore and instanceId first, because they are the keys)

    function createSeries(address creatorCore, uint256 instanceId, uint24 maxSupply, string calldata prefix, Recipient[] memory recipients) external override creatorAdminRequired(creatorCore) {
    if (instanceId > MAX_UINT_56 || maxSupply == 0 || _editionInfo[creatorCore][instanceId].maxSupply != 0) revert InvalidInput();
    uint8 creatorContractVersion;
        try IERC721CreatorCoreVersion(creatorContractAddress).VERSION() returns(uint256 version) {
            require(version <= 255, "Unsupported contract version");
            creatorContractVersion = uint8(version);
        } catch {}
    _editionInfo[creatorCore][instanceId] = EditionInfo({
         maxSupply: maxSupply,
         tokenPrefix: tokenPrefix,
         contractVersion: creatorContractVersion,
    })