Add Mint Fees as config param to claims #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LCOV of commit
|
wwhchung
reviewed
Feb 20, 2024
| @@ -33,8 +33,7 @@ contract ERC1155LazyPayableClaim is IERC165, IERC1155LazyPayableClaim, ICreatorE | |||
| interfaceId == type(IERC165).interfaceId; | |||
| } | |||
|
|
|||
| constructor(address initialOwner, address delegationRegistry, address delegationRegistryV2) LazyPayableClaim(initialOwner, delegationRegistry, delegationRegistryV2) {} | |||
|
|
|||
| constructor(address initialOwner, address delegationRegistry, address delegationRegistryV2, uint256 mintFee, uint256 mintFeeMerkle) LazyPayableClaim(initialOwner, delegationRegistry, delegationRegistryV2, mintFee, mintFeeMerkle) {} | |||
There was a problem hiding this comment.
Fix ordering, put mint fees first.
wwhchung
reviewed
Feb 20, 2024
| @@ -47,7 +47,7 @@ contract ERC721LazyPayableClaim is IERC165, IERC721LazyPayableClaim, ICreatorExt | |||
| interfaceId == type(IERC165).interfaceId; | |||
| } | |||
|
|
|||
| constructor(address initialOwner, address delegationRegistry, address delegationRegistryV2) LazyPayableClaim(initialOwner, delegationRegistry, delegationRegistryV2) {} | |||
| constructor(address initialOwner, address delegationRegistry, address delegationRegistryV2, uint256 mintFee, uint256 mintFeeMerkle) LazyPayableClaim(initialOwner, delegationRegistry, delegationRegistryV2, mintFee, mintFeeMerkle) {} | |||
There was a problem hiding this comment.
Fix ordering, put mint fees first (convention is to put static variables first.
wwhchung
reviewed
Feb 20, 2024
| @@ -72,12 +72,13 @@ abstract contract LazyPayableClaim is ILazyPayableClaim, AdminControl { | |||
| _; | |||
| } | |||
|
|
|||
| constructor(address initialOwner, address delegationRegistry, address delegationRegistryV2) { | |||
| constructor(address initialOwner, address delegationRegistry, address delegationRegistryV2, uint256 mintFee, uint256 mintFeeMerkle) { | |||
There was a problem hiding this comment.
Fix ordering, put mint fees first (convention is to put static variables first.
|
You need to update the deploy scripts and set it to switch on a network environment variable. The deploy scripts should have the hardcoded amounts. |
.github/workflows/ci.yml
Outdated
| @@ -20,10 +20,10 @@ jobs: | |||
| ref: ${{ github.event.pull_request.head.ref }} | |||
| repository: ${{ github.event.pull_request.head.repo.full_name }} | |||
|
|
|||
| - name: Set Node to v16 | |||
| - name: Set Node to v18 | |||
There was a problem hiding this comment.
I think we're on 20 now
|
Closing this because it won't work and will result in different contract addresses across different networks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates mint fees to be initialization params
moves MINT_FEE and MINT_FEE_MERKLE to be constructor params to allow for variable mint fee to for allowing for different fees to be charged on different networks.