Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add deprecate func for gacha extension #94

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

nikki-kiga
Copy link
Contributor

This PR

Screenshots (if applicable)

Ticket

https://linear.app/manifoldxyz/issue/UPDATE-THIS-PART

CR Notes

QA Steps

  • [ ]

Copy link

github-actions bot commented Jun 7, 2024

LCOV of commit f539f7b during Test! #421

Summary coverage rate:
  lines......: 55.1% (1271 of 2306 lines)
  functions..: 57.1% (237 of 415 functions)
  branches...: 42.5% (528 of 1242 branches)

Files changed coverage rate: n/a

Copy link
Contributor

@jaxonL jaxonL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

active claims are still supported by deprecated contracts im assuming (which makes sense), tho it may be kinda nightmarish for us to support haha

Comment on lines +53 to +55
function deprecate(bool _deprecated) external adminRequired {
deprecated = _deprecated;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o neat

@nikki-kiga nikki-kiga merged commit cd148f2 into main Jun 7, 2024
7 checks passed
@nikki-kiga nikki-kiga deleted the gacha-deprecate branch June 7, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants