-
Notifications
You must be signed in to change notification settings - Fork 208
Create Appimage #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Create Appimage #728
Conversation
changed .github/workflows/build.yml to build the AppImage
…/packaging/debian/control as Ubuntu miss some Debian deps
Thanks a lot! The Fedora dependency issues are being resolved. Regarding the appimage workflow, would it be possible to also build the qt variant instead of only gtk? Which qt6 dependencies are missing from debian/ubuntu exactly? |
… properties: run, shell, uses, with, working-directory removed -name: Check out code
I made the changes to support generation of both GTK and QT5 AppImage (mainly name the package with the suffix -gtk or -qt5). The script is ready for QT6 too, and work locally on my Debian13. Anyway I left commented in: |
is there something wrong with PR? |
Sorry this fell of my radar. If you have no objections I would try to use a fedora base image to get the qt6 variant building, since qt5 is pretty obsolete nowadays. |
apparently github support only Ubuntu as Linux distro, see: |
Unfortunately, recent distros no longer support QT5 (missing package "libqtspell-qt5-dev"), so you have to use two different distros to generate QT5 and QT6. I looked up how to use Docker to generate AppImages on a distro newer than Ubuntu 24.04. I tested it with Debian 13, which I know well because FUSE must be enabled. |
See [1], the outer container is indeed ubuntu, but you can run a fedora container within that container. [1] https://github.com/manisandro/gImageReader/blob/master/.github/workflows/build.yml#L7 |
in the new file: |
is there something wrong with this PR? |
If you are not interested in AppImage generation just say so. Please review this PR or reject it |
I dig a little in Github action to generate a CI binaries. I take inspiration from your yml file, thanks. Here the results:
https://github.com/efa/gImageReader/releases/tag/ci-latest
Note1:
As Github has image for Ubuntu and not for Debian, and I cannot find some QT6*dev packages (maybe freespell), I had to switch to this list of deps with Qt5:
https://github.com/manisandro/gImageReader/blob/master/packaging/debian/control
and not this one with Qt6:
https://salsa.debian.org/debian/gimagereader/-/blob/main/debian/control
Note 2:
I do not know why, but as now:
https://github.com/manisandro/gImageReader/blob/master/.github/workflows/build.yml
always fail for some Fedora deps error:
https://github.com/efa/gImageReader/actions/runs/17052058157/job/48341834644
This is not related to my new file:
https://github.com/efa/gImageReader/blob/appimage/.github/workflows/linux.yml
Note 3:
The similar old PR: #708
is now overcome and closed