Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme.org - ZMK Docker Build Subsection #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

axiom-nz
Copy link

Issue

The Local Build section of readme.org specifies that ZMK_CONFIG be set to the absolute path of the config directory.

When using the local docker build environment, following these instructions would lead the user to create their zmk-config docker volume with a device path set to config.

Doing so will exclude the Miryoku code from the volume, and any build will fail.

Failing Build

With miryoku_zmk/config provided as the device path.

docker volume create --driver local -o o=bind -o type=none -o device="/var/code/miryoku_zmk/config" zmk-config 

west build -p -d build/right -b nice_nano_v2 -- -DSHIELD=corne_right -DZMK_CONFIG="/workspaces/zmk-config/"
image

Resolution

Adding subsection to the local build documentation to inform those using the docker build environment of this, and give instructions on the correct path.

Successful Build

With miryoku_zmk provided as the device path.

docker volume create --driver local -o o=bind -o type=none -o device="/var/code/miryoku_zmk/" zmk-config 

west build -p -d build/right -b nice_nano_v2 -- -DSHIELD=corne_right -DZMK_CONFIG="/workspaces/zmk-config/config"
image

Let me know if there is any issue with this, or if you would like it phrased differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant