Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the issue of social media links opening in the same tab #1226

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

Ravi-1606
Copy link
Contributor

@Ravi-1606 Ravi-1606 commented Nov 9, 2024


name: Pull Request Template
about: Use this template for creating pull requests
title: '[FIX] Social media links now open in a new tab'
labels: 'bug, enhancement'
assignees: 'RaviChoudhary'


Description

  • This pull request addresses an issue where social media links on the site were not opening in a new tab, causing users to navigate away from the main site unintentionally.

  • The bug was fixed by adding target="_blank" to each social media link, ensuring that they now open in a new browser tab or window. This improves user experience by allowing users to access external social media pages without leaving the main site.

  • Fixes [Bug]: Social Media Links Open in Same Tab, Affecting User Experience #1033

  • This pull request fixes the bug where social media links didn't open in a new tab. I resolved this by adding target="_blank" to each link.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the contributing document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added necessary tests to ensure my changes are effective.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

vercel bot commented Nov 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bobble-ai-rcmb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2024 7:09am

Copy link

github-actions bot commented Nov 9, 2024

👋 Thank you for opening this pull request! We're excited to review your contribution. Please give us a moment, and we'll get back to you shortly!

Feel free to join our community on Discord to discuss more!

@Ravi-1606
Copy link
Contributor Author

@mansiruhil13 I encountered some issues with my previous pull request related to the commit, so I've submitted a new one. Apologies for any inconvenience caused. Please review and let me know if there are any remaining issues.

@Ravi-1606
Copy link
Contributor Author

@mansiruhil13 , could you please review and accept my PR? Today is the final day for GSSOC submissions, and no new PRs will be accepted after 7 PM. Your prompt action would be greatly appreciated. Thank you!

@mansiruhil13 mansiruhil13 merged commit c8856de into mansiruhil13:main Nov 10, 2024
3 checks passed
Copy link

🚀 Thank you for your contribution! This pull request has been closed. If you have any questions or need further assistance, feel free to reach out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Social Media Links Open in Same Tab, Affecting User Experience
2 participants