Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover animation added on all pages with responsive icons. #427

Merged
merged 35 commits into from
Oct 8, 2024

Conversation

rajdeepchakraborty-rc
Copy link
Contributor

Issue #333 [SOLVED]

Updated the Newsletter

Social.Icons_Hover.animation.mp4

Since I have updated most of the things, thus I am only adding the video of the work done.

@rajdeepchakraborty-rc
Copy link
Contributor Author

The site is broken!
image
image

@mansiruhil13
Copy link
Owner

The site is broken! image image

yes but assigned recently

@rajdeepchakraborty-rc
Copy link
Contributor Author

Seems like somebody resolved a wrong merge conflict (accepted both changes rather than choosing one)

@rajdeepchakraborty-rc
Copy link
Contributor Author

Somebody has messed up with my code pretty bad

image

I would love to know who this person is who thought of adding a dropdown on social icons.

@mansiruhil13
Copy link
Owner

Screenshot 2024-10-09 001059
resolve conflicts

@rajdeepchakraborty-rc
Copy link
Contributor Author

@mansiruhil13 Somehow after lot of merge conflicts later... I have resolved it.

@rajdeepchakraborty-rc
Copy link
Contributor Author

I was uploading the change. That is why you were seeing the conflicts. You had again merged some code a while back. had to resolve that too.

@rajdeepchakraborty-rc
Copy link
Contributor Author

I have to admit that working on this issue was really something. I can set this issue a record of merge conflicts. I have lost count at this point of how many times I have resolved the code.

@rajdeepchakraborty-rc
Copy link
Contributor Author

Not again!

@mansiruhil13
Copy link
Owner

I have to admit that working on this issue was really something. I can set this issue a record of merge conflicts. I have lost count at this point of how many times I have resolved the code.

yes, there are many issues created. 😅

@mansiruhil13
Copy link
Owner

Not again!

resolve conflicts

@rajdeepchakraborty-rc
Copy link
Contributor Author

I have to admit that working on this issue was really something. I can set this issue a record of merge conflicts. I have lost count at this point of how many times I have resolved the code.

yes, there are many issues created. 😅

No worries. Even you are having a hard timing manage the code. Ok ma'am, as you wish. I shall dive into the code conflict again.

@rajdeepchakraborty-rc
Copy link
Contributor Author

@mansiruhil13 I hereby present myself to you once again

@mansiruhil13 mansiruhil13 merged commit dc4f379 into mansiruhil13:main Oct 8, 2024
2 checks passed
Copy link

github-actions bot commented Oct 8, 2024

🚀 Thank you for your contribution! This pull request has been closed. If you have any questions or need further assistance, feel free to reach out.

@rajdeepchakraborty-rc
Copy link
Contributor Author

Thanks for reviewing! Please assign the PR to me.

@rajdeepchakraborty-rc
Copy link
Contributor Author

rajdeepchakraborty-rc commented Oct 8, 2024

@mansiruhil13 Also close the issue #333 and assign this PR to me.

@rajdeepchakraborty-rc
Copy link
Contributor Author

rajdeepchakraborty-rc commented Oct 8, 2024

@mansiruhil13 Thanks for assigning the PR. Sorry for irritating you so much during this PR review😅
I have some other issues pending. Once I am done working on them, I will get back to committing more to this project. Hope you have a great day/night ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants