fix pystack test

qt/python/mantidqt/mantidqt/dialogs/errorreports/run_pystack.py

@@ -18,19 +18,19 @@
 log = Logger("errorreports (pystack analysis)")
 
 
-def retrieve_thread_traces_from_coredump_file() -> bytes | None:
+def retrieve_thread_traces_from_coredump_file() -> bytes:
     # Locate the core dumps dir
     core_dumps_path = None
     try:
         core_dumps_path = _get_core_dumps_dir()
     except ValueError as e:
         log.error(str(e))
-        return None
+        return b""
 
     # Get most recent dump file, check it's python (can you check it's from workbench?)
     core_file = _get_most_recent_core_dump_file(core_dumps_path)
     if core_file is None:
-        return None
+        return b""
 
     # Run file through pystack and capture output
     pystack_output = _get_output_from_pystack(core_file)

qt/python/mantidqt/mantidqt/dialogs/errorreports/test/test_run_pystack.py

@@ -5,17 +5,23 @@
 #   Institut Laue - Langevin & CSNS, Institute of High Energy Physics, CAS
 # SPDX - License - Identifier: GPL - 3.0 +
 
+from pathlib import Path
 from tempfile import NamedTemporaryFile, TemporaryDirectory
 from time import sleep
 from unittest import TestCase
 from unittest.mock import MagicMock, patch
 
+from mantid.kernel.environment import is_linux
 from mantidqt.dialogs.errorreports.run_pystack import _get_core_dumps_dir, _get_most_recent_core_dump_file
 
 
 class TestRunPystack(TestCase):
     MODULE_PATH = "mantidqt.dialogs.errorreports.run_pystack"
 
+    def setUp(self) -> None:
+        if not is_linux():
+            self.skipTest("pystack is only run on linux")
+
     @patch(f"{MODULE_PATH}.ConfigService")
     def test_get_core_dumps_dir_raises_if_not_set(self, mock_config_service: MagicMock):
         mock_config_service.getString.return_value = ""
@@ -24,13 +30,13 @@ def test_get_core_dumps_dir_raises_if_not_set(self, mock_config_service: MagicMo
     @patch(f"{MODULE_PATH}.ConfigService")
     def test_get_core_dumps_dir_raises_if_does_not_exist(self, mock_config_service: MagicMock):
         mock_config_service.getString.return_value = "/a/fake/path"
-        self.assertRaisesRegex(ValueError, "errorreports.core_dumps value (/a/fake/path) does not exist", _get_core_dumps_dir)
+        self.assertRaisesRegex(ValueError, "does not exist", _get_core_dumps_dir)
 
     @patch(f"{MODULE_PATH}.ConfigService")
     def test_get_core_dumps_dir_raises_if_file_is_set(self, mock_config_service: MagicMock):
         with NamedTemporaryFile() as tmp_file:
             mock_config_service.getString.return_value = tmp_file.name
-            self.assertRaisesRegex(ValueError, f"errorreports.core_dumps value ({tmp_file.name}) is not a directory", _get_core_dumps_dir)
+            self.assertRaisesRegex(ValueError, "is not a directory", _get_core_dumps_dir)
 
     @patch(f"{MODULE_PATH}.ConfigService")
     def test_get_core_dumps_dir_returns_a_dir_set_in_the_config(self, mock_config_service: MagicMock):
@@ -49,16 +55,16 @@ def test_get_most_recent_core_dump_file_gets_the_latest_file(self, mock_check_wo
             for name in file_names:
                 open(f"{tmp_dir}/{name}", "a").close()
                 sleep(0.1)
-            latest_file = _get_most_recent_core_dump_file(tmp_dir)
+            latest_file = _get_most_recent_core_dump_file(Path(tmp_dir))
             self.assertEqual(latest_file.name, file_names[-1])
 
     @patch(f"{MODULE_PATH}.CORE_DUMP_RECENCY_LIMIT", 0.5)
     def test_get_most_recent_core_dump_file_returns_none_if_there_are_no_new_files(self):
         with TemporaryDirectory() as tmp_dir:
             open(f"{tmp_dir}/test", "a").close()
             sleep(0.6)
-            self.assertIsNone(_get_most_recent_core_dump_file(tmp_dir))
+            self.assertIsNone(_get_most_recent_core_dump_file(Path(tmp_dir)))
 
     def test_get_most_recent_core_dump_file_returns_none_if_the_dir_is_empty(self):
         with TemporaryDirectory() as tmp_dir:
-            self.assertIsNone(_get_most_recent_core_dump_file(tmp_dir))
+            self.assertIsNone(_get_most_recent_core_dump_file(Path(tmp_dir)))