Skip to content

Commit

Permalink
Update cppcheck to 2.16.0
Browse files Browse the repository at this point in the history
This is a squashed version of #38459

fix typo to trigger cppcheck run

Remove cppcheck suppressions temporarily for cppcheck update

Update cppcheck to 2.16.0

Suppress class_X_Y cppcheck warnings.

Restrict cppcheck to unix only. There is no 2.16.0 for Windows.

We can re-add it for Windows in the future if it is reinstated.
For the time being, since nobody is running it locally, we don't really
need it to be installed on Windows.

Sort cppcheck supressions by file name and line number

Group internal cppcheck errors to extract them from the bounty list

Update cppcheck suppressions for v2.16.0
  • Loading branch information
thomashampson authored and peterfpeterson committed Jan 16, 2025
1 parent 1254c3a commit 8d63a99
Show file tree
Hide file tree
Showing 5 changed files with 1,104 additions and 1,074 deletions.
2 changes: 1 addition & 1 deletion Framework/Algorithms/src/ConvertToConstantL2.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ void ConvertToConstantL2::exec() {
throw std::runtime_error(errorMsg.str());
}

// subract the diference in l2
// subtract the difference in l2
double thisDetL2 = inputSpecInfo.l2(i);
double deltaL2 = std::abs(thisDetL2 - m_l2);
double deltaTOF = calculateTOF(deltaL2);
Expand Down
6 changes: 4 additions & 2 deletions buildconfig/CMake/CommonSetup.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -151,9 +151,11 @@ endif()
include(ClangTidy)

# ######################################################################################################################
# Setup cppcheck
# Setup cppcheck - temporarily exclude from Windows because 2.16 isn't available yet
# ######################################################################################################################
include(CppCheckSetup)
if(NOT WIN32)
include(CppCheckSetup)
endif()

# ######################################################################################################################
# Set up the unit tests target
Expand Down
Loading

0 comments on commit 8d63a99

Please sign in to comment.