Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for legacy file format in DNS Reduction GUI #36385

Merged

Conversation

koshchii
Copy link
Member

@koshchii koshchii commented Nov 8, 2023

Description of work

Summary of work

Fixes #36065.

Further detail of work

This PR implements support for loading legacy file format in DNS Reduction GUI. More specifically:

  • The neutron polarisation channel is determined automatically using the values of "currents" provided in the B-fields section of a legacy file
  • Legacy filenames can be handled properly at the script generation stage

To test:

  • Download test data:

  • Open the reduction GUI [Interfaces->Direct->DNS Reduction]

    Repeat the steps below for present and legacy format files and make sure that the outcome is identical

  • Browse to the directory where the test data are located using the "Paths" tab of the GUI

  • Load and select the data for reduction using the "Data" tab

  • Choose the data reduction options using the "Options" tab

  • Reduce the data and generate a data reduction script using the "Script Generator" tab

  • Visualize the results using the "Plotting" tab


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@koshchii koshchii added this to the Release 6.9 milestone Nov 9, 2023
@koshchii koshchii added GUI Issues and pull requests specific to the Mantid Workbench GUI. MLZ Team Issue and pull requests managed by the MLZ development team labels Nov 9, 2023
@koshchii koshchii marked this pull request as ready for review November 13, 2023 12:11
Copy link
Member

@peterfpeterson peterfpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look reasonable and only appear to affect DNS data reduction

@sf1919 sf1919 merged commit e4fbd1f into mantidproject:main Dec 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI Issues and pull requests specific to the Mantid Workbench GUI. MLZ Team Issue and pull requests managed by the MLZ development team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legacy file format support for DNS Reduction GUI
3 participants