-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for legacy file format in DNS Reduction GUI #36385
Merged
sf1919
merged 17 commits into
mantidproject:main
from
koshchii:dns_gui_add_support_for_legacy_format
Dec 14, 2023
Merged
Support for legacy file format in DNS Reduction GUI #36385
sf1919
merged 17 commits into
mantidproject:main
from
koshchii:dns_gui_add_support_for_legacy_format
Dec 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koshchii
added
GUI
Issues and pull requests specific to the Mantid Workbench GUI.
MLZ Team
Issue and pull requests managed by the MLZ development team
labels
Nov 9, 2023
peterfpeterson
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look reasonable and only appear to affect DNS data reduction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Summary of work
Fixes #36065.
Further detail of work
This PR implements support for loading legacy file format in DNS Reduction GUI. More specifically:
B-fields
section of a legacy fileTo test:
Download test data:
Open the reduction GUI [Interfaces->Direct->DNS Reduction]
Repeat the steps below for present and legacy format files and make sure that the outcome is identical
Browse to the directory where the test data are located using the
"Paths"
tab of the GUILoad and select the data for reduction using the
"Data"
tabChoose the data reduction options using the
"Options"
tabReduce the data and generate a data reduction script using the
"Script Generator"
tabVisualize the results using the
"Plotting"
tabReviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.