-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old Data analysis tab classes #36389
Merged
MialLewis
merged 33 commits into
mantidproject:main
from
robertapplin:0-refactor-by-removing-individual-analysis-tab-classes
Nov 30, 2023
Merged
Remove old Data analysis tab classes #36389
MialLewis
merged 33 commits into
mantidproject:main
from
robertapplin:0-refactor-by-removing-individual-analysis-tab-classes
Nov 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35a388d
to
cbe87b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the refactoring, now the code is cleaner. Just a few comments
qt/scientific_interfaces/Inelastic/Analysis/FunctionBrowser/FqFunctionModel.h
Show resolved
Hide resolved
qt/scientific_interfaces/Inelastic/Analysis/IndirectFitOutputOptionsView.cpp
Outdated
Show resolved
Hide resolved
cbe87b7
to
75e2a07
Compare
MohamedAlmaki
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tabs work as expected. Thanks for enhancing the code quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Indirect/Inelastic
Issues and pull requests related to indirect or inelastic
ISIS Team: Spectroscopy
Issue and pull requests managed by the Spectroscopy subteam at ISIS
Maintenance
Unassigned issues to be addressed in the next maintenance period.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
This PR removes the
ConvFitTab
,MSDFitTab
,IqtFitTab
andFqFitTab
classes. Since the move to MVP a few years ago in the Data Analysis interface, all the functions for the tabs should be in the relevant Model-View-Presenter files for the relevant section of the GUI. This PR finally removes these classes so that new functionality is not added into them anymore.Some of the changes might look a bit messy, but this is because this is only a stepping stone. There is still a lot of refactoring to do in this area, in particular surrounding the
IndirectDataAnalysisTab
class. I will continue with this refactor in a separate PR so that this one does not get too large. I have opened an issue to continue refactoring #36390There is no associated issue.
To test:
Interfaces
Inelastic Data Analysis
Add Workspace
for each tab and enter the data below for the corresponding tabsRun
Plot Spectra
orPlot
(depending on the tab). TryPlot Tiled
on theIqt
tab (accessed via the down arrow on thePlot Spectra
button)Also try moving around the range selectors on the embeded plots (the dashed vertical lines).
Test Data
MSDFit Tab
Input file: osi92762_graphite002_elwin_eq.zip
Select Fit Type:
MSDGauss
IqtFit Tab
Input file: irs26176_graphite002_iqt.zip
Tick
Stretched Exponential
Select
Flat background
Note: drag the EndX on the graph to the left a bit to miss the noise (
0.15
I think)ConvFit Tab
Input files: irs26176_graphite002_red.zip
irs26173_graphite002_res.zip
Select Fit Type:
Two Lorenztian
F(Q) Tab
Input file: IN16B_125878_QLd_Result.zip
Select Fit Type:
Chudley Elliott
This does not require release notes because it is an internal refactor
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.