Remove QObjects from ALCFitting Presenter and Model

[cailafinn]

Description of work

Summary of work

Stops the presenter and the model from being QObjects, replacing their signals and slots with functionality based on the observer pattern where the presenter (as an observer) subscribes to the view and the model and is updated on their progress.

As part of this, the view and model no longer directly communicate, making this compliant with MVP principles.

Fixes #38007

Further detail of work

Tests have been updated with new mocks to test the implemented functionality independently of any changes to the other parts of the MVP structure.

To test:

1. Run through the tests here: https://developer.mantidproject.org/Testing/MuonAnalysis_test_guides/Muon_ALC.html#alc-peak-fitting

This does not require release notes because no user-facing functionality should have changed.

---

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

• Is the code of an acceptable quality?
• Does the code conform to the coding standards?
• Are the unit tests small and test the class in isolation?
• If there is GUI work does it follow the GUI standards?
• If there are changes in the release notes then do they describe the changes appropriately?
• Do the release notes conform to the release notes guide?

Functional Tests

• Do changes function as described? Add comments below that describe the tests performed?
• Do the changes handle unexpected situations, e.g. bad input?
• Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

[adriazalvarez]

Trying to do the manual testing, there are two problems:
On the baseline fitting step, there are three legends on the plot after fitting:

And the data for the peak is not carried over to the peak fitting tab (it is empty):

[cailafinn]

Thanks for the review @adriazalvarez
Would you be able to provide the data you used for the test? I struggled to find it in any of the Usage/Sample data sets.

[adriazalvarez]

It was not local data.I followed the first test (https://developer.mantidproject.org/Testing/MuonAnalysis_test_guides/Muon_ALC.html#alc-peak-fitting) of the manual testing instructions (run numbers 81061-142).

[cailafinn]

And the data for the peak is not carried over to the peak fitting tab (it is empty)

This actually seems to be an issue on main, but I'll fix it as part of this PR.

[adriazalvarez]

Tested the interface and everything works correctly on the peak fitting tab.
It's a nice implementation of the MVP pattern with subscribers and is a clean and clear refactorization. I have found very small issues that in some cases are just questions. But it looks good otherwise.
Also, I have checked(I didn't when I tested initially) that the recent refactorization for the MVP training of the baseline presenter was already on the code, and the issue I experienced initially was a bug with that, but thanks a lot for fixing it anyway!

[github-actions]

👋 Hi, @cailafinn,

Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

[adriazalvarez]

Thanks for the changes, peak fitting is working correctly and the interface organization is much improved.