Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mantid help email link to help menu #38253

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

jhaigh0
Copy link
Contributor

@jhaigh0 jhaigh0 commented Oct 21, 2024

Description of work

Added mailto:[email protected] link to the Help menu.

There is no associated issue.

To test:

  • Click Help->Email [email protected]
  • It should open a new email in your default email program

If it's not working, using this page to test mailto links
https://www.scottseverance.us/mailto.html


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@jhaigh0 jhaigh0 added the ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS label Oct 21, 2024
@jhaigh0 jhaigh0 added this to the Release 6.12 milestone Oct 21, 2024
@robertapplin robertapplin self-assigned this Oct 23, 2024
Copy link
Contributor

@robertapplin robertapplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simple but useful change that works as expected 👍

@SilkeSchomann SilkeSchomann self-assigned this Oct 23, 2024
@SilkeSchomann SilkeSchomann merged commit e0ae9d6 into main Oct 23, 2024
10 checks passed
@SilkeSchomann SilkeSchomann deleted the mailto_help_button branch October 23, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants