Move nexus reading code - ornl-next #38436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a squashed version of mantidproject#38379 Use NexusHDF5Descriptor for LoadMcStas algorithm Use HDF5 library directly to separate event and histogram entries Add H5 utility functions Read instrument xml from H5File handle Use HDF5 API to read event slabs Get detector ID to workspace Index map outside of for loop Use HDF5 api for loading histogram entry data Only pass group path and no type to readEventData Avoid copying read vector upon return Remove unused header includes Use H5::H5Object where possible instead of templated type Use H5 cpp api for confidence check Avoid copying string attribute upon return Fix cppcheck warnings Read string attribute as a std::string Update tests in LoadMcStasTest
This is a squashed version of mantidproject#38406 Move H5Util file to Framework/Nexus library Remove unused includes and add where appropriate Fix cppcheck warnings in loading code
peterfpeterson
added
ornl-next
peterfpeterson
merged commit b9af344
into
mantidproject:ornl-next
9 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls the following work into
ornl-nextH5Utilfile to Mantid::Nexus library #38406