Fix logic for checking bin consistency in ConjoinWorkspaces algorithm #38619
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
A check was added to
ConjoinWorkspaces
here to verify that the input workspaces have consistent binning. It was using the functionWorkspaceHelpers::matchingBins
, but this also enforces that the number of histograms is the same for both input workspaces. This is not what we wanted. It is fixed in this PR.There is no associated issue.
To test:
BinWidth
parameter of one of the input workspaces and verify that you get the error about non-matching bins.BinWidth
s, add the parameterCheckMatchingBins=False
as an argument to the ConjoinWorkspaces call and verify that the algorithm runs as expected without any error messages.This does not require release notes because it was a bug that was introduced as part of another fix
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.