CPPCheck Team Bravo Set 50 #38716
Open
CPPCheck Team Bravo Set 50 #38716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiveDataAlgorithm destructor set to override
plus invalidPointerCasting from int to double.
TCPEventStreamDefs unsignedPositive was comparing an int to an uint32.
Despiix
added
the
Maintenance
Despiix
force-pushed
the
cpp-check-Set-50
branch
7 times, most recently
from
11284e3 to
f41d0ff
Compare
…in TCPEventStreamDefs.h Suppressed some because they worked correctly. Explanations are written in comments above suppressions. Co-authored-by: thomashampson <[email protected]> Co-authored-by: Jonathan Haigh <[email protected]>
Despiix
force-pushed
the
cpp-check-Set-50
branch
from
f41d0ff to
0dd88b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Summary of work
There is no associated issue.
Further detail of work
Set 50: http://172.16.111.171/suppressionSet.php?setid=50To test:
Check if all of the issues in set 50 are fixed correctly
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.