Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LoadNexusMonitors V1 algorithm #39022

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sf1919
Copy link
Contributor

@sf1919 sf1919 commented Mar 6, 2025

Description of work

Removal of deprecated LoadNexusMonitors v1 algorithm.

Summary of work

LoadNexusMonitors v1 algorithm was deprecated in v3.9 (#18322). This is the removal of that algorithm and any links to it.

Part of #39011

Further detail of work

Removal of algorithm files, updating of CMake and removal of all documentation links.

To test:

  • tests should pass
  • Check correct files have been removed
  • Check correct lines have been removed from CMake
  • Check there are no further links/references to LoadNexusMonitors v1

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@sf1919
Copy link
Contributor Author

sf1919 commented Mar 7, 2025

Genuine test failures

@sf1919 sf1919 added the ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS label Mar 11, 2025
@sf1919 sf1919 added this to the Release 6.13 milestone Mar 11, 2025
@sf1919 sf1919 marked this pull request as ready for review March 11, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant