Live Viewer Intensity plotted correctly with slow/faulty files #2488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeSullivan7
force-pushed
the
2497_LV_Intensity_slow_files
branch
from
fbd6721 to
c6af5a8
Compare
MikeSullivan7
changed the title
samtygier-stfc
requested changes
Jan 30, 2025
| @@ -50,11 +51,14 @@ def _remove_oldest_image(self) -> None: | |||
| def use_loading_function(self, func: typing.Callable) -> None: | |||
| self.loading_func = func | |||
|
|
|||
| def load_image(self, image: Image_Data) -> np.ndarray: | |||
| def load_image(self, image: Image_Data) -> np.ndarray | None: | |||
There was a problem hiding this comment.
Does this need to be np.ndarray | None, it looks like it either returns the array or raises an exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Closes #2487
Description
The Live Viewer is now triggered to update images both when an image enters the directory (e.g. when an incomplete file is transferred) and when an image is modified (e.g. when the file has finished transferring). A custom exception class
ImageLoadFailErroris now used to catch errors involved when attempting to load a faulty file. Exception handling is used to prevent the intensity from being calculated for an incomplete file, both when a file enters and when the ROI is moved.Developer Testing
Both unit tests and system tests pass on both Windows and Linux
Acceptance Criteria and Reviewer Testing
make check,make test-systempython scripts/simulate_live_data.py -s /data/imaging/tof/MCP_Fe_Calibration/Fe_Powder_Run1_PH60_Dis50mm_NewShutter/Corrected/ -d /tmp/live_test/ -r 1 --mode slowDocumentation and Additional Notes
[ ] Release Notes have been updated