Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ROI movement not updating spectrum unless selected #2489

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ashleymeigh2
Copy link
Collaborator

Issue Closes #2486

Description

  • Fixed an issue where moving an ROI did not update the spectrum plot unless the ROI was selected first.
  • roi_changed signal now correctly emits the SpectrumROI object instead of an ROI or string.
  • Updated handle_roi_moved to process only the moved ROI for efficiency.
  • Ensured remove_roi correctly retrieves and passes the SpectrumROI object to the presenter.

Developer Testing

  • I have verified unit tests pass locally: python -m pytest -vs
  • Manually tested by:
    • Adding an ROI and moving it.
    • Checking that the spectrum updates immediately without needing selection.
    • Removing an ROI and verifying spectrum updates correctly.

Acceptance Criteria and Reviewer Testing

  • Unit tests pass locally: python -m pytest -vs
  • Adding a new ROI updates the spectrum on resize.
  • Moving an existing ROI updates the spectrum in real-time.
  • Removing an ROI updates the spectrum correctly.

Documentation and Additional Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spectrum plot not updating
2 participants