Implement APIEndpointAsset's fetch_api_data functionality #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimventures
approved these changes
Aug 28, 2023
| body = json.loads(json.dumps(self.body).replace('%query%', query)) | ||
|
|
||
| # Send the request | ||
| response = requests.post(self.url, headers=headers, json=body, timeout=15) |
There was a problem hiding this comment.
What happens if this times out? If run in the context of a job, it will likely blow things up pretty badly :D
There was a problem hiding this comment.
it'll raise a Timeout exception. I'll wrap it in a try/except and, if caught, raise the same RequestException as below. That should make it easy to handle them in the executor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to implement functionality that allows Chirps to make an API request to an
APIEndpointAsset. The query included in the request POST body will be generated during a scan, and the entire response from the request will be parsed to determine if the response includes the pre-defined success outcome. If not, another query will be generated and the process repeated.