This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
Replace _ from mesos task name by - #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously underscores where removed when creating the service name. This usually does not correspond to the intent of the user since he set a separator in the task name. In the specific case of marathon, the folder separator is converted to underscore when creating a mesos task. Users in marathon sets: /mygroup/mysubgroup/myapp Tasks name is mesos are: mygroup_mysubgroup_myapp.[guid] Before this patch, consul service names were mygroupmysubgroupmyapp After this patch, consul service names are mygroup-mysubgroup-myapp. Fixes mantl#63
|
@ChrisAubuchon I've implemented the configurable separator. I would be happy if any of these two commits are merged. |
|
It doesn't look like the separator is configurable. There needs to be a |
kamaradclimber
force-pushed
the
separator
branch
from
5cc62e0 to
a5e00f1
Compare
|
you're right, fixed |
ChrisAubuchon
added a commit
that referenced
this pull request
Feb 22, 2016
Replace _ from mesos task name by -
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously underscores where removed when creating the service name.
This usually does not correspond to the intent of the user since he set
a separator in the task name.
In the specific case of marathon, the folder separator is converted to
underscore when creating a mesos task.
Users in marathon sets: /mygroup/mysubgroup/myapp
Tasks name is mesos are: mygroup_mysubgroup_myapp.[guid]
Before this patch, consul service names were mygroupmysubgroupmyapp
After this patch, consul service names are mygroup-mysubgroup-myapp.
Fixes #63