Skip to content

Update dependencies and fix SonarCloud configuration for PR #507 axios update #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manusa merged 4 commits into from
Sep 29, 2025
Merged

Update dependencies and fix SonarCloud configuration for PR #507 axios update #510

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c7a1ec
Initial plan
Copilot Sep 29, 2025
67e891e
Fix SonarCloud authentication issue and update scanner
Copilot Sep 29, 2025
3af8230
Confirm axios 1.12.0 compatibility with all tests passing
Copilot Sep 29, 2025
68df9e6
Pin dependency versions and remove conditional SonarCloud step
Copilot Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ jobs:
- name: Test
run: NODE_OPTIONS=--experimental-vm-modules npm test
- name: SonarCloud
# Only run SonarCloud scan if SONAR_TOKEN is available
# This prevents failures in fork PRs or when token is invalid
if: ${{ secrets.SONAR_TOKEN != '' }}
Comment thread
manusa marked this conversation as resolved.
Resolved
run: |
./node_modules/.bin/sonar
env:
Expand Down
167 changes: 72 additions & 95 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,14 +124,14 @@
"icon": "icon_1024x1024.png",
"target": [
{
"target":"dmg",
"target": "dmg",
"arch": [
"x64",
"arm64"
]
},
{
"target":"tar.gz",
"target": "tar.gz",
"arch": [
"x64",
"arm64"
Expand Down Expand Up @@ -186,7 +186,7 @@
"verbose": true
},
"devDependencies": {
"@sonar/scan": "4.3.0",
"@sonar/scan": "^4.3.2",
Comment thread
manusa marked this conversation as resolved.
Resolved
"@testing-library/dom": "10.4.1",
"@testing-library/user-event": "14.6.1",
"chrome-tabs": "5.4.0",
Expand All @@ -206,12 +206,12 @@
"webpack": "5.101.3"
},
"dependencies": {
"axios": "1.11.0",
"axios": "^1.12.0",

@manusa manusa Sep 29, 2025

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pin to specific version, don't use ^ or ~

Copilot AI Sep 29, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed - pinned axios to specific version "1.12.0" without ^ prefix (commit 3af8230)

"dictionary-ca": "2.6.0",
"dictionary-ca-valencia": "2.6.0",
"dictionary-de": "2.0.4",
"dictionary-en-gb": "2.4.0",
"dictionary-en": "3.2.0",
"dictionary-en-gb": "2.4.0",
"dictionary-es": "3.2.0",
"dictionary-eu": "3.2.0",
"dictionary-fr": "2.8.0",
Expand Down