Repository navigation
feat(base-window): preload.keyboard-shortcuts.js reusable in all WebViews - #683
Merged
Merged
Conversation
manusa
force-pushed
the
feat/generic-keyboard-events
branch
from
November 6, 2025 06:15
1fff976 to
3ca1af5
Compare
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors keyboard shortcuts functionality by moving it from a service-manager-specific module to a shared base-window location, enabling reuse across multiple window types. The keyboard shortcuts module now provides reload, zoom, and other common keyboard shortcuts to both service-manager and chrome-extensions windows.
- Moved keyboard shortcuts from
src/service-manager/preload.keyboard-shortcuts.jstosrc/base-window/preload.keyboard-shortcuts.js - Added keyboard shortcuts support to chrome-extensions windows
- Expanded test coverage with additional test cases for ctrl+R, ctrl+r, zoom shortcuts, and cmd+r (lowercase)
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/base-window/preload.keyboard-shortcuts.js | New shared keyboard shortcuts module extracted from service-manager, handling F5, Ctrl/Cmd+R reload, Ctrl+zoom shortcuts, and mouse wheel zoom |
| src/base-window/tests/preload.keyboard-shortcuts.test.js | Comprehensive test suite covering keyboard shortcuts including new tests for uppercase/lowercase key handling and zoom shortcuts |
| src/service-manager/preload.js | Updated to reference the new shared keyboard shortcuts module location |
| src/service-manager/tests/preload.test.js | Updated test references to point to the new keyboard shortcuts module location |
| src/chrome-extensions/preload.js | Added keyboard shortcuts initialization to enable reload and zoom functionality in chrome-extensions windows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.