[Copilot]

Screen sharing E2E tests were flaky due to implicit state dependencies between nested describe blocks. When one beforeAll failed (e.g., sources didn't load), subsequent blocks would fail due to unexpected overlay state.

Changes

• Add state management helpers at test suite level:

  • isOverlayVisible() - Safe visibility check with error handling
  • ensureOverlayClosed() - Actively closes overlay if open
  • openOverlay() - Opens overlay and waits for visibility
  • waitForSources() - Waits for sources with 15s timeout (up from 10s)

• Make each beforeAll self-sufficient:

  describe('canceling screen sharing', () => {
    beforeAll(async () => {
      await ensureOverlayClosed();  // Clean state first
      await openOverlay();          // Then set up required state
    });

• Remove source dependency from cancel test - Cancellation doesn't require sources to be loaded, so that wait was removed. Cancel tests now pass independently even when desktopCapturer.getSources() is slow.

• Increase timeouts for slow CI environments (10s → 15s for sources, 5s → 10s for other waits)

• Remove misleading test - "displays loading message initially" was checking after sources already loaded in beforeAll

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• product-details.mozilla.org
  • Triggering command: /home/REDACTED/work/electronim/electronim/node_modules/electron/dist/electron /home/REDACTED/work/electronim/electronim/node_modules/electron/dist/electron -r /home/REDACTED/work/electronim/electronim/node_modules/playwright-core/lib/server/electron/loader.js --inspect=0 --remote-debugging-port=0 /home/REDACTED/work/electronim/electronim/src/index.js --no-sandbox --disable-gpu --disable-dev-shm-usage --disable-web-security --settings-path /tmp/electronim-test-8JS8e9/settings.json --user-data /tmp/electronim-test-8JS8e9 (dns block)
  • Triggering command: /home/REDACTED/work/electronim/electronim/node_modules/electron/dist/electron /home/REDACTED/work/electronim/electronim/node_modules/electron/dist/electron -r /home/REDACTED/work/electronim/electronim/node_modules/playwright-core/lib/server/electron/loader.js --inspect=0 --remote-debugging-port=0 /home/REDACTED/work/electronim/electronim/src/index.js --no-sandbox --disable-gpu --disable-dev-shm-usage --disable-web-security --settings-path /tmp/electronim-test-U2sGgW/settings.json --user-data /tmp/electronim-test-U2sGgW (dns block)
  • Triggering command: /home/REDACTED/work/electronim/electronim/node_modules/electron/dist/electron /home/REDACTED/work/electronim/electronim/node_modules/electron/dist/electron -r /home/REDACTED/work/electronim/electronim/node_modules/playwright-core/lib/server/electron/loader.js --inspect=0 --remote-debugging-port=0 /home/REDACTED/work/electronim/electronim/src/index.js --no-sandbox --disable-gpu --disable-dev-shm-usage --disable-web-security --settings-path /tmp/electronim-test-CB0DXS/settings.json --user-data /tmp/electronim-test-CB0DXS (dns block)
• redirector.gvt1.com
  • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --enable-crash-reporter=587d066a-7cca-41e1-a468-c4e4da4d326b,no_channel --user-data-dir=/tmp/electronim-test-8JS8e9 --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,12253100954382321867,14441367336904052304,262144 --enable-features=CDPScreenshotNewSurface,PdfUseShowSaveFilePicker --disable-features=AcceptCHFrame,AutoDeElevate,AvoidUnnecessaryBeforeUnloadCheckSync,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,LocalNetworkAccessChecks,MediaRouter,PaintHolding,RenderDocument,ScreenA (dns block)
  • Triggering command: /home/REDACTED/work/electronim/electronim/node_modules/electron/dist/electron /home/REDACTED/work/electronim/electronim/node_modules/electron/dist/electron -r /home/REDACTED/work/electronim/electronim/node_modules/playwright-core/lib/server/electron/loader.js --inspect=0 --remote-debugging-port=0 /home/REDACTED/work/electronim/electronim/src/index.js --no-sandbox --disable-gpu --disable-dev-shm-usage --disable-web-security --settings-path /tmp/electronim-test-8JS8e9/settings.json --user-data /tmp/electronim-test-8JS8e9 (dns block)
  • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --enable-crash-reporter=6e7e65aa-36d5-4bcf-a67d-ee8458c72a37,no_channel --user-data-dir=/tmp/electronim-test-U2sGgW --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,3380794546204715699,1712745992657695642,262144 --enable-features=CDPScreenshotNewSurface,PdfUseShowSaveFilePicker --disable-features=AcceptCHFrame,AutoDeElevate,AvoidUnnecessaryBeforeUnloadCheckSync,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,LocalNetworkAccessChecks,MediaRouter,PaintHolding,RenderDocument,ScreenA (dns block)
• versionhistory.googleapis.com
  • Triggering command: /home/REDACTED/work/electronim/electronim/node_modules/electron/dist/electron /home/REDACTED/work/electronim/electronim/node_modules/electron/dist/electron -r /home/REDACTED/work/electronim/electronim/node_modules/playwright-core/lib/server/electron/loader.js --inspect=0 --remote-debugging-port=0 /home/REDACTED/work/electronim/electronim/src/index.js --no-sandbox --disable-gpu --disable-dev-shm-usage --disable-web-security --settings-path /tmp/electronim-test-8JS8e9/settings.json --user-data /tmp/electronim-test-8JS8e9 (dns block)
  • Triggering command: /home/REDACTED/work/electronim/electronim/node_modules/electron/dist/electron /home/REDACTED/work/electronim/electronim/node_modules/electron/dist/electron -r /home/REDACTED/work/electronim/electronim/node_modules/playwright-core/lib/server/electron/loader.js --inspect=0 --remote-debugging-port=0 /home/REDACTED/work/electronim/electronim/src/index.js --no-sandbox --disable-gpu --disable-dev-shm-usage --disable-web-security --settings-path /tmp/electronim-test-U2sGgW/settings.json --user-data /tmp/electronim-test-U2sGgW (dns block)
  • Triggering command: /home/REDACTED/work/electronim/electronim/node_modules/electron/dist/electron /home/REDACTED/work/electronim/electronim/node_modules/electron/dist/electron -r /home/REDACTED/work/electronim/electronim/node_modules/playwright-core/lib/server/electron/loader.js --inspect=0 --remote-debugging-port=0 /home/REDACTED/work/electronim/electronim/src/index.js --no-sandbox --disable-gpu --disable-dev-shm-usage --disable-web-security --settings-path /tmp/electronim-test-CB0DXS/settings.json --user-data /tmp/electronim-test-CB0DXS (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

The tests in src/tests/screen-sharing.test.e2e.js
are still quite flaky.

We've already tried to fix some of the issues with this tests (there are failures that no longer happen).

But still I can see some tests fail from time to time.

Could you ultra analyze this and see if we can fix the flakiness.
Maybe waiting for a specific component before proceeding with the test and so on.
We already implemented some of these fixes in other parts of the suite and other e2e tests.

The latest errored run is in the next link

https://productionresultssa7.blob.core.windows.net/actions-results/48bc8f72-77cc-4daf-9b83-c309e963b4b0/workflow-job-run-0789ce3f-89c5-5a21-977a-1298b697b659/logs/job/job-logs.txt?rsct=text%2Fplain&se=2025-11-29T05%3A45%3A11Z&sig=O8XUlZtKpVBiutAGlN%2BDlE14Kp4pq29IRwPhZabhAcU%3D&ske=2025-11-29T14%3A17%3A00Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2025-11-29T02%3A17%3A00Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2025-11-05&sp=r&spr=https&sr=b&st=2025-11-29T05%3A35%3A06Z&sv=2025-11-05

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud