Fix func_conveyor "SetSpeed" not properly reading float input #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code credit goes to Verttox from the momentum mod repo (but really alien swarm) https://togithub.com/momentum-mod/game/pull/346/commits/c4cdba18480de6e6665ef46f3bb535a1c6e15b43 (togithub.com redirect cause crosslink bumps are cringe) Anyway heres a video of it working in my custom edit of mapbase: https://github.com/meatspace/storage/raw/refs/heads/main/setspeed.mp4 Im not a coder so ymmv or whatever. just thought id suggest it.
|
If speed setting works, conveyors need to keep track of their current offset, otherwise you'll get a jump whenever they change speed. Could be a follow up though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code credit goes to Verttox from the momentum mod repo
https://togithub.com/momentum-mod/game/pull/346/commits/c4cdba18480de6e6665ef46f3bb535a1c6e15b43 (togithub.com redirect cause crosslink bumps are cringe)
Anyway heres a video of it working in my custom edit of mapbase: https://github.com/meatspace/storage/raw/refs/heads/main/setspeed.mp4
Im not a programmer so ymmv. I don't THINK it breaks anything. I specifically did not include the other half of the commit that changes m_flSpeed to 0 which I believe would break existing maps. (idk how to make that code optional, perhaps you can do that)
Does this PR close any issues?
no
PR Checklist
developbranch OR targets another branch with a specific goal in mind