Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New item_battery_custom entity #369

Conversation

Blixibon
Copy link
Member

This PR adds a new item_battery_custom entity as an analogue to item_healthkit_custom.


PR Checklist

  • My PR follows all guidelines in the CONTRIBUTING.md file
  • My PR targets a develop branch OR targets another branch with a specific goal in mind

Copy link

@1upD 1upD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because I don't see any issues, but I'm curious - why does item_battery_custom need to be a separate class from item_battery? Couldn't the latter support model replacement?

@Blixibon
Copy link
Member Author

In addition to model replacement, item_battery_custom also supports a custom power amount. That functionality could have been added to item_battery_custom as well, but I thought it would be more appropriate to split it off.

@Blixibon Blixibon merged commit 496cbe7 into mapbase-source:develop Mar 1, 2025
4 checks passed
@Blixibon Blixibon deleted the mapbase/feature/item-battery-custom branch March 1, 2025 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants