Eliminate switching between hot and cold sources #1026
Conversation
This switching causes severe flickering and there seems to be no performance advantage at least in our use case. See: <mapbox#871> <mapbox#916>
|
It reduces the number of layers in the map. In my case, i would say that it even improves performance ! Thanks @vhautsal |
|
This solves a flicker issue I was having. Hope it gets merged soon 🎉 |
|
Adding for reference #296 |
|
Hi @vhautsal, Thanks for the contribution, and sorry for the delayed response! Could you please rebase on top of the |
|
We are facing flicker issue also; would be great to get this merged! @vhautsal @stepankuzmin |
|
any update on this? |
|
Bump - we need this fix in please. The flickering of the map caused by the issue is not good |
|
Please do merge it why delaying, app does not look good with flickering. |
|
nudge |
|
Hi @vhautsal Any update on this PR? |
|
Unfortunately there's not much I can do. I synced my branch with upstream a year ago, but nothing happened then. Apparently there are some new conflicts now, but after nearly four years of waiting, I'm not interested in trying to keep up unless some Mapbox API change forces us to update. @LukasGrubis @stepankuzmin |
|
We ended up forking this repo and manually implementing this fix. Can confirm that it entirely removes the flickering without any obvious side effect / performance degradations |
|
Would it be possible for you to create a pull request with your changes and fixes? |
I copied the changes from this pr. |
|
Thanks for sharing, @jonas-nordtorp ! Since you've already copied the changes from this PR, would you consider resolving the conflicts and submitting a pull request to help move this fix closer to being included in the official release? I'm sure many of us in the community would greatly appreciate it! |
|
Created a new pull request that fixes the conflicts here: |
Switching between two sources causes severe flickering and there seems to be no performance advantage at least in our use case.
Related issues:
#871
#916