Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated controls ordering and UI tooltips to be consistent with keybindings #1209

Closed
wants to merge 0 commits into from

Conversation

georgemoon
Copy link

At some point the Mapbox Draw keybindings were changed, and are now:

(1) Point
(2) Line
(3) Polygon

whereas the tooltips still have the letters l/p/m.

This pull request changes the tooltips, and also the ordering of the controls to be consistent with the numbering used.

Addresses #1103

Copy link
Contributor

@stepankuzmin stepankuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks @georgemoon 👍

@georgemoon
Copy link
Author

Hey @underoot @stepankuzmin, I think this change is still relevant but doesn't appear to have been included in the latest refactor. Could you maybe take another look? It's a relatively simple fix! Thanks

@underoot
Copy link
Member

underoot commented Dec 4, 2024

Hey, @georgemoon! You are right, by mistake your changes haven't been included into v1.5.0. I've refreshed PR branch and changes for some reasons weren't reflected in GitHub and I thought that changes already propogated to main. I've created #1320 to follow-up and indeed merge changes. Thank you!

@georgemoon
Copy link
Author

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants