bugfix: properties.mode is not available on vertex and midpoint, fixes #1077

[varna]

properties.mode is not available on vertex and midpoint.

Styles filter for mode on vertex and midpoint doesn't work, because lib/create_vertex and lib/create_midpoint does not extend feature_types/feature like other styles.

mapbox-gl-js version: 3.4.0
mapbox-gl-draw version: 1.4.3

Steps to Trigger Behavior

1. Read https://github.com/mapbox/mapbox-gl-draw/blob/main/docs/API.md#styling-draw
2. Copy https://github.com/mapbox/mapbox-gl-draw/blob/main/src/lib/theme.js into your project
3. Edit vertex or midpoint style in accordance to mode, i.e.

// before

export default [
 // ...
 {
   id: "gl-draw-polygon-and-line-vertex-stroke-inactive",
   type: "circle",
   filter: [
     "all",
     ["==", "meta", "vertex"],
     ["==", "$type", "Point"],
     ["!=", "mode", "static"]
   ],
   paint: {
     "circle-radius": 5,
     "circle-color": "#fff"
   }
 },
 {
   id: "gl-draw-polygon-and-line-vertex-inactive",
   type: "circle",
   filter: [
     "all",
     ["==", "meta", "vertex"],
     ["==", "$type", "Point"],
     ["!=", "mode", "static"]
   ],
   paint: {
     "circle-radius": 3,
     "circle-color": "#fbb03b"
   }
 },
 // ...
]

// after adding `["!=", "mode", "simple_select"]` to each filter

export default [
  // ...
  {
    id: "gl-draw-polygon-and-line-vertex-stroke-inactive",
    type: "circle",
    filter: [
      "all",
      ["==", "meta", "vertex"],
      ["==", "$type", "Point"],
      ["!=", "mode", "static"],
      ["!=", "mode", "simple_select"]
    ],
    paint: {
      "circle-radius": 5,
      "circle-color": "#fff"
    }
  },
  {
    id: "gl-draw-polygon-and-line-vertex-inactive",
    type: "circle",
    filter: [
      "all",
      ["==", "meta", "vertex"],
      ["==", "$type", "Point"],
      ["!=", "mode", "static"],
      ["!=", "mode", "simple_select"]
    ],
    paint: {
      "circle-radius": 3,
      "circle-color": "#fbb03b"
    }
  },
  // ...
]

Expected Behavior

Vertexes should be gone on active features during simple_select mode.

Actual Behavior

Rules seems to be ignored.

Attribution

This solution is extracted from #1078 made on Oct 28, 2021. That PR has a great video explanation of problem and solution. The PR itself has "more things" to it, like changes to theme. I extracted only the fix, to make it more of a atomic PR in hopes that someone from Mapbox team could merge this bugfix instead of waiting two years for nothing.

[varna]

Hey @stepankuzmin,

Sorry for tagging you, but you seem to be the most active maintainer of this repo. Do you think it's possible to poke someone to merge a couple of bugfixes to this library? Or should I just give up and live on a fork?

[stepankuzmin]

Hi @varna,

Thanks for the contribution, and I'm sorry for the slow response. We are working on some fixes and plan to release a new version of GL Draw.