-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize 2024 #1242
Modernize 2024 #1242
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Why do we need ESBuild though if we still use Rollup?
You are right, we don't need to transpile with esbuild for older browsers anymore 👍 |
d191167
to
9da02f4
Compare
9da02f4
to
0a1e9f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Something I've been doing recently is also removing tape and nyc in favor of native Node test runner and coverage — see if it makes sense to do so here, but not too important.
buble
compilerand switch to theesbuild
xtend
, useObject.assign
insteadlodash.isequal
, usefast-deep-equal
insteadvite
for the local developmentThe minified bundle size dropped from 80K to 68K.
The benchmarks primarily use the previous setup.