[ios] Fix flaky GeoJsonSource tests #593
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use StyleManager/addSource(_:dataId:) so GeoJsonSource's data will be applied in a background queue. - Add a delay in GeoJsonSource test when checking for volatile properties, since these properties are added later after the source is added to the style.
maios
force-pushed
the
MAPSFLT-141_fix-ios-geojson-tests
branch
from
2d6a052
to
4119cb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO It might be better for us to adopt StyleDSL from both platforms to Flutter. I created an internal ticket to track work
Pull request checklist: