[ios] Adapt GesturesManager/onMapTap and onMapLongPress #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We should take advantage of existing gesture recognizers of MapView, namely onMapTap and onMapLongPress.
|
Great. Thank you. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
We should take advantage of existing gesture recognizers of MapView, namely onMapTap and onMapLongPress.
Remove extra tap and long press recognizer in GesturesController, replace them with
onMapTapandonMapLongPressThis should fix #605 as
onMapLongPresswill emit events when the long press is recognized (after a minimum press duration), current approach with target/action will report event when the fingers are lifted off the screen.Pull request checklist: