-
Notifications
You must be signed in to change notification settings - Fork 26
Setup Travis CI to have a job to build the source code #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
131f9b0
to
c4c70e6
Compare
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
c4c70e6
to
e635e4e
Compare
e635e4e
to
3bd21d7
Compare
f7b35b3
to
5772769
Compare
b19a1d8
to
ab6e8e3
Compare
b4a676f
to
2982213
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have two suggestions, the rest looks good
|
||
echo "Retrying in several seconds" | ||
echo | ||
sleep $[ ( $RANDOM % 20 ) + 1 ]s # 1-20 seconds random sleep, time interval to check flag next time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should add a max number of tries or summary duration of the tries? there can be problems with network connection, or with the mapbox-vision repository, or something else
################### | ||
|
||
if [[ $# -gt 0 ]]; then | ||
while [[ $# -gt 0 ]]; do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
while [[ $# -gt 0 ]]; do | |
for argument in "$@" do |
and without shift
command below
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Checks:
dev
branchLinked issues:
Resolves #156