Skip to content

Conversation

dersim-davaod
Copy link
Contributor

Checks:

  • Update changelog
  • Rebase to dev branch
  • Assign reviewers

Linked issues:
Resolves #156

@dersim-davaod dersim-davaod added this to the Sprint 12 milestone Oct 15, 2019
@dersim-davaod dersim-davaod self-assigned this Oct 15, 2019
@stale
Copy link

stale bot commented Nov 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the staled marked by stalebot according to config label Nov 29, 2019
@dersim-davaod dersim-davaod force-pushed the 156-setup-travis-ci-to-have-a-build-jobs branch from 131f9b0 to c4c70e6 Compare December 5, 2019 13:03
@stale stale bot removed the staled marked by stalebot according to config label Dec 5, 2019
@stale
Copy link

stale bot commented Jan 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the staled marked by stalebot according to config label Jan 19, 2020
@dersim-davaod dersim-davaod force-pushed the 156-setup-travis-ci-to-have-a-build-jobs branch from c4c70e6 to e635e4e Compare March 11, 2020 12:03
@stale stale bot removed the staled marked by stalebot according to config label Mar 11, 2020
@dersim-davaod dersim-davaod force-pushed the 156-setup-travis-ci-to-have-a-build-jobs branch from e635e4e to 3bd21d7 Compare April 9, 2020 11:41
@dersim-davaod dersim-davaod removed this from the Sprint 12 milestone Apr 9, 2020
@dersim-davaod dersim-davaod force-pushed the 156-setup-travis-ci-to-have-a-build-jobs branch 2 times, most recently from f7b35b3 to 5772769 Compare April 9, 2020 13:58
@dersim-davaod dersim-davaod force-pushed the 156-setup-travis-ci-to-have-a-build-jobs branch 2 times, most recently from b19a1d8 to ab6e8e3 Compare April 9, 2020 14:11
@dersim-davaod dersim-davaod marked this pull request as ready for review April 9, 2020 14:42
@dersim-davaod dersim-davaod force-pushed the 156-setup-travis-ci-to-have-a-build-jobs branch from b4a676f to 2982213 Compare April 14, 2020 15:16
Copy link
Contributor

@IodaMikeMapbox IodaMikeMapbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have two suggestions, the rest looks good


echo "Retrying in several seconds"
echo
sleep $[ ( $RANDOM % 20 ) + 1 ]s # 1-20 seconds random sleep, time interval to check flag next time
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should add a max number of tries or summary duration of the tries? there can be problems with network connection, or with the mapbox-vision repository, or something else

###################

if [[ $# -gt 0 ]]; then
while [[ $# -gt 0 ]]; do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
while [[ $# -gt 0 ]]; do
for argument in "$@" do

and without shift command below

@stale
Copy link

stale bot commented Jul 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the staled marked by stalebot according to config label Jul 11, 2020
@chezzdev chezzdev removed their request for review January 12, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS operation excellence P1 Good to have staled marked by stalebot according to config
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants