Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update versions for release to central #2931

Merged
merged 2 commits into from
May 17, 2021
Merged

Conversation

mikepthomas
Copy link
Contributor

@mikepthomas mikepthomas commented Nov 7, 2020

Upgraded the dependency versions and pushed to sonatype snapshots

You are able to get a snapshot of release 1.4.2-SNAPSHOT by adding the following to your maven pom:

    <dependencies>
        <dependency>
            <groupId>org.mapeditor</groupId>
            <artifactId>libtiled</artifactId>
            <version>1.4.2-SNAPSHOT</version>
            <type>jar</type>
        </dependency>
    </dependencies>
    <repositories>
        <repository>
            <id>sonatype-oss</id>
            <url>https://oss.sonatype.org/content/repositories/snapshots/</url>
            <snapshots>
                <enabled>true</enabled>
            </snapshots>
        </repository>
    </repositories>

You can inspect the contents of the archives from here
Please let me know if you are happy with the release and I will kick off the deploy to maven central

@bjorn
Copy link
Member

bjorn commented Nov 10, 2020

Thanks @mikepthomas!

I think before we hit the release button, it would be nice to also include the just merged #2932 and to wait a bit so see if we should include #2934.

@bjorn
Copy link
Member

bjorn commented Apr 27, 2021

@mikepthomas Seems like waiting on clarity about #2934 was a bad call. Can we just push a new version, making sure #2932 and the recent #3004 are included?

@mikepthomas
Copy link
Contributor Author

@mikepthomas Seems like waiting on clarity about #2934 was a bad call. Can we just push a new version, making sure #2932 and the recent #3004 are included?

I have just updated this branch with all changes in master branch of your repo and pushed another snapshot and pre-release to OSS https://oss.sonatype.org/#nexus-search;gav~org.mapeditor~libtiled~1.4.2-SNAPSHOT~jar~ it would be good to get a second pair of eyes on it to ensure its all good and when you are happy i'll get it deployed to Maven Central

@bjorn
Copy link
Member

bjorn commented Apr 28, 2021

I'm not sure I'm a good second pair of eyes regarding Java packages. Maybe @Sam-Manflame, @hoxu or @csueiras could have a look? (sorry for the mention if you're not interested)

@bjorn bjorn merged commit 3f8eddf into mapeditor:master May 17, 2021
@bjorn
Copy link
Member

bjorn commented May 17, 2021

@mikepthomas Unfortunately none of the previous contributors have responded. I've had a quick look and this version bump looks fine to me. The only thing I'm wondering regarding future version updates, is whether we can make them a little less verbose:

  • The @version attributes seem useless to me. Maybe we can just remove them?
  • I don't think we need to bump the versions of all the files in the autotests, except when something would have changed about them.
  • I'm still not sure why we'd bump copyright years apart from for the changed files. And even for changed files, it would be more accurate to include the people who actually made the changes rather than bumping the year for all the listed contributors.

Anyway, again this is just for future updates. For now I've just merged this.

Please deploy this new version to Maven Central. :-)

@mikepthomas
Copy link
Contributor Author

That all sounds good to me. The new version is now available in Maven Central https://search.maven.org/artifact/org.mapeditor/libtiled/1.4.2/jar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants