Scripting: Replaced TileMap.selectedArea with TileMap.selectedRegion #3556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new property has type `region` instead of `SelectedArea`, with the goal of unifying region values in the JS API.
|
Accidentally merged... undone using force-push, but there appears to be no way to reopen this PR, heh. Edit: replaced by #3557. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new property has type
regioninstead ofSelectedArea, with the goal of unifying region values in the JS API.Remaining issues with this change:
Qt.recttoselectedRegion. I'm not sure if this can be fixed by adding overloads for the setter.tiled.region(...)that can create either a empty or rectangular region.