Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose basic properties of Tiled projects to scripting #3622

Merged
merged 13 commits into from
Mar 21, 2023

Conversation

dogboydog
Copy link
Contributor

related to #2902

@bjorn bjorn changed the title 2902 - Expose basic properties of Tiled projects to scripting Expose basic properties of Tiled projects to scripting Mar 17, 2023
docs/scripting-doc/index.d.ts Outdated Show resolved Hide resolved
src/tiled/editableproject.h Show resolved Hide resolved
src/tiled/editableproject.cpp Outdated Show resolved Hide resolved
@dogboydog
Copy link
Contributor Author

Eishiya and I weren't sure if it makes sense to add the project file path to tiled.project.fileName since there is already tiled.projectFilePath

@bjorn
Copy link
Member

bjorn commented Mar 20, 2023

Eishiya and I weren't sure if it makes sense to add the project file path to tiled.project.fileName since there is already tiled.projectFilePath

Yeah, I wasn't sure about that myself either, which is why I hadn't asked you to add it. But I think there is no harm in adding this. We may want to deprecate the other property then.

src/tiled/scriptmodule.cpp Outdated Show resolved Hide resolved
@bjorn bjorn merged commit 5113f40 into mapeditor:master Mar 21, 2023
@dogboydog dogboydog deleted the 2902-project-scripting branch March 21, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants