Draft: add-set-padding-function #267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianBissekkou
commented
Jul 3, 2023
Comment on lines
341
to
344
|
|
||
|
|
||
| mapView.contentInset = UIEdgeInsets(top: CGFloat(top), left: CGFloat(left), bottom: CGFloat(bottom), right: CGFloat(right)) | ||
| result(nil) |
There was a problem hiding this comment.
Once you did the open todos you will eventually adjust this line of code and call this method with the provided animation duration. Keep in mind 2 things:
- most iOS apis treat animation durations as seconds (where others use ms)
- Add a completion handler to the call and only invoke
result(nil)once the animation is done
JulianBissekkou
commented
Jul 3, 2023
lib/src/controller.dart
Outdated
| @@ -276,6 +276,11 @@ class MaplibreMapController extends ChangeNotifier { | |||
| return _mapboxGlPlatform.animateCamera(cameraUpdate, duration: duration); | |||
| } | |||
|
|
|||
| Future<bool?> setPadding({required EdgeInsets edgeInsets}) async { | |||
| //TODO(tapped-matthias): don't animate by default = Duration.zero | |||
There was a problem hiding this comment.
@huberm88
Can you take a look. If you have questions let me know 👍🏽
JulianBissekkou
commented
Jul 3, 2023
lib/src/controller.dart
Outdated
| @@ -276,6 +276,11 @@ class MaplibreMapController extends ChangeNotifier { | |||
| return _mapboxGlPlatform.animateCamera(cameraUpdate, duration: duration); | |||
| } | |||
|
|
|||
| Future<bool?> setPadding({required EdgeInsets edgeInsets}) async { | |||
There was a problem hiding this comment.
Small rename to be consistent with the framework 👍🏽
Suggested change
| Future<bool?> setPadding({required EdgeInsets edgeInsets}) async { | |
| Future<bool?> setPadding({required EdgeInsets padding}) async { |
JulianBissekkou
commented
Jul 3, 2023
example/lib/animate_camera.dart
Outdated
Comment on lines
188
to
195
| TextButton( | ||
| onPressed: () { | ||
| mapController.setPadding( | ||
| edgeInsets: const EdgeInsets.only(right: 300.0), | ||
| ); | ||
| }, | ||
| child: const Text('addRightPadding'), | ||
| ), |
There was a problem hiding this comment.
We should create a new example screen that shows the padding feature in more detail, otherwise its quite hard to debug and test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.