New android sdk version #270
Conversation
| @@ -86,110 +86,6 @@ public void onDetachedFromActivity() { | |||
| lifecycle = null; | |||
| } | |||
|
|
|||
| // Old Plugin APIs | |||
|
|
|||
| public static void registerWith(Registrar registrar) { | |||
There was a problem hiding this comment.
This was not used, but please again if we could really drop that.
There was a problem hiding this comment.
That should be fine
There was a problem hiding this comment.
I just checked, because I was curious: the new APIs were introduced in Flutter 1.12, so this should indeed be safe to remove as you noted. (https://docs.flutter.dev/release/breaking-changes/plugin-api-migration)
Maybe we could still add a note to the changelog if we are already documenting the new min android sdk.
There was a problem hiding this comment.
I added some information to the Changelog file. Should be fine now.
|
I also removed two files, since there was no single reference. Please take also take care about that in the review:
|
| @@ -86,110 +86,6 @@ public void onDetachedFromActivity() { | |||
| lifecycle = null; | |||
| } | |||
|
|
|||
| // Old Plugin APIs | |||
|
|
|||
| public static void registerWith(Registrar registrar) { | |||
There was a problem hiding this comment.
That should be fine
No description provided.