Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS example: pin pod versions #276

Closed
wants to merge 2 commits into from

Conversation

m0nac0
Copy link
Collaborator

@m0nac0 m0nac0 commented Aug 8, 2023

I want to add new pod versions of the MapLibre pod (m0nac0/flutter-maplibre-podspecs#2).

I think it's a good idea to pin the MapLibre native version here and then explicitly update it after we have tested the new MapLibre native version.

I want to add new pod versions of the MapLibre pod (m0nac0/flutter-maplibre-podspecs#2).

I think it's a good idea to pin the MapLibre native version here and then explicitly update it after we have tested the new MapLibre native version.
Comment on lines +7 to +8
pod 'MapLibre', '5.12.2'
pod 'MapLibreAnnotationExtension', '0.0.1-beta.2'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We removed MapLibreAnnotationExtension in #277 and pinned it to 5.14.0-pre1.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest that remove MapLibreAnnotationExtension and add it back once we have a flutter api that uses which is not the case right now

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess #277 can make this PR obsolete. My only question would be, if developers still need to specify the dependency in the example/ios/Podfile at all?
If yes, we can change the that file and the Readme to the new version in #277

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kuhnroyal Do you have some insight into whether developers still need to list the dependency in their podfile like we do in the example app, and if yes, is there some way we can tell Flutter to automatically add it to their Podfile?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If MapLibre is available in cocaopods trunk (which it seems to be: https://github.com/CocoaPods/Specs/tree/master/Specs/b/0/0/MapLibre) and MapLibreAnnotationExtension is removed, then there is no need to specify anything manually.
If MapLibreAnnotationExtension is required again in the future, then it should also be published via cocoapods and then no manual listing is required either.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, that sounds good. So I'll close this PR and open a new one to remove these lines.

@m0nac0 m0nac0 closed this Aug 14, 2023
m0nac0 added a commit that referenced this pull request Aug 23, 2023
As noted in #276, developers shouldn't need to adapt their Podfiles
anymore, since Maplibre is now a published pod and the dependency on
MaplibreAnnotationExtension is removed in #277.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants