Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(example): responsive design #421

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

chore(example): responsive design #421

wants to merge 16 commits into from

Conversation

josxha
Copy link
Collaborator

@josxha josxha commented May 20, 2024 •
edited
Loading

  • responsive design for main page
  • link to pub.dev and github from the main page
  • update icons
  • delete unused example/READEME.md file

@josxha josxha added this to the v0.19.0 milestone May 20, 2024
@josxha josxha requested a review from kuhnroyal May 20, 2024 13:25
@josxha josxha self-assigned this May 20, 2024
@josxha josxha modified the milestones: v0.19.0, v0.20.0 May 21, 2024
kuhnroyal
kuhnroyal approved these changes Jun 2, 2024
View reviewed changes
Copy link
Collaborator

@kuhnroyal kuhnroyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
The sample crashes on my iOS simulator, same for you?
This is unrelated to this PR tho.

@josxha
Copy link
Collaborator Author

josxha commented Jun 2, 2024

Thanks for the review!
I can't test on the iOS Simulator because i don't have a up-to-date mac but I it doesn't crash for me when running on appetize.io (an iOS emulator on the web). Could it be that your problem is related to #388?

I'd like to do more work on the example app, mostly making it completely responsive. Do you prefer it in multiple pull requests or would one bigger pr be fine for you?

@kuhnroyal
Copy link
Collaborator

I don't mind bigger PRs for the example app :)
That issues you linked is probably the reason, thanks.

@josxha
Merge branch 'main' into feat/update-example-app
f10f7a9
@josxha
Merge branch 'main' into feat/update-example-app
a9a4371
@josxha
Squashed commit of the following:
b30dbab 
commit baa8496
Merge: 9a7e082 a9a4371
Author: Joscha <[email protected]>
Date:   Mon Jun 3 21:03:35 2024 +0200

    Merge branch 'feat/update-example-app' into feat/update-example-app-2

commit 9a7e082
Author: Joscha <[email protected]>
Date:   Mon Jun 3 20:41:17 2024 +0200

    Update local_style_page.dart

commit adf9ab9
Author: Joscha <[email protected]>
Date:   Mon Jun 3 20:34:36 2024 +0200

    responsive annotation layout

commit 7284235
Author: Joscha <[email protected]>
Date:   Mon Jun 3 09:35:52 2024 +0200

    Update user_interface_page.dart

commit 2773f73
Author: Joscha <[email protected]>
Date:   Mon Jun 3 01:47:28 2024 +0200

    responsive layout

    missing: annotation pages

commit 7c588aa
Author: Joscha <[email protected]>
Date:   Mon Jun 3 00:25:34 2024 +0200

    reorder items on main page

commit 0ac575d
Author: Joscha <[email protected]>
Date:   Mon Jun 3 00:10:57 2024 +0200

    improve structure, rename routes

commit 6c5a3ca
Author: Joscha <[email protected]>
Date:   Sun Jun 2 23:53:07 2024 +0200

    rename files according to the widget names

commit 40f0be4
Author: Joscha <[email protected]>
Date:   Sun Jun 2 23:24:06 2024 +0200

    use named routes
@josxha josxha changed the title chore(example): responsive main page design chore(example): responsive design Jun 3, 2024
@josxha
Copy link
Collaborator Author

josxha commented Jun 3, 2024

@kuhnroyal this pull request got big quick 😅 I changed the example app to use Wraps for it's buttons and expanded the map widget for a better experience on large screens. Additionally I moved the buttons to the top to reduce the distance between them and the back button. Still no award-winning layout, but hopefully an improvement. No functionality should have been touched. Let me know if you want anything to get changed.

@josxha josxha requested a review from kuhnroyal June 3, 2024 19:33
@josxha josxha modified the milestones: v0.20.0, v0.20.1 Jun 7, 2024
@josxha
Copy link
Collaborator Author

josxha commented Jun 7, 2024

ngx-maplibre-gl has a great showcase: https://maplibre.org/ngx-maplibre-gl/demo/display-map
Maybe we can do something similar in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuhnroyal kuhnroyal Awaiting requested review from kuhnroyal

Assignees

@josxha josxha

Labels
None yet
Projects
None yet
Milestone
v0.20.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@josxha @kuhnroyal