Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use lints from very_good_analysis #434

Merged
merged 7 commits into from
Jun 2, 2024

Conversation

josxha
Copy link
Collaborator

@josxha josxha commented Jun 2, 2024

This pull request swaps out the basic flutter_lints ruleset for a more strict one, in this case the one from very_good_analysis because it gets used often in other projects and is well maintained.
I made it that all packages reference the same lint file with the option to change the behavior for some if needed.

  • very_good_analysis has the same lower sdk bound as we, so it matches quite well.
  • I added all the lints to be ignored temporarily. Most of them are code smells, the use of dynamic typing, undocumented code or hints where code can be refactored to be more clean in general.

@josxha josxha added this to the v0.20.0 milestone Jun 2, 2024
@josxha josxha requested a review from kuhnroyal June 2, 2024 14:00
@josxha josxha self-assigned this Jun 2, 2024
@josxha josxha merged commit 0d2b5ed into maplibre:main Jun 2, 2024
9 checks passed
@josxha josxha deleted the feat/use-very_good_analysis branch June 2, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants