Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example app android build #439

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

kuhnroyal
Copy link
Collaborator

  • bump compileSdkVersion to 34
  • bump Java source/target compatibility to Java 17
  • use specific NDK version required by path_provider package
  • remove old platform package workaround
  • remove v21 resources since the min target is 21
  • remove empty MainActivity
  • adjust package name & namespace
  • use gradle-bin distribution for faster download
  • remove kotlin-stdlib-jdk7 - this is bundled since Kotlin 1.8

This will probably not fix the problems in #406 but is a cleaner baseline with less other problems.

* bump `compileSdkVersion` to 34
* bump Java source/target compatibility to Java 17
* use specific NDK version required by `path_provider` package
* remove old `platform` package workaround
* remove `v21` resources since the min target is 21
* remove empty `MainActivity`
* adjust package name & namespace
* use gradle-bin distribution for faster download
* remove `kotlin-stdlib-jdk7` - this is bundled since Kotlin 1.8
@kuhnroyal kuhnroyal requested a review from josxha June 4, 2024 11:02
@kuhnroyal kuhnroyal self-assigned this Jun 4, 2024
Copy link
Collaborator

@josxha josxha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kuhnroyal kuhnroyal merged commit 66174a7 into maplibre:main Jun 4, 2024
9 checks passed
@kuhnroyal kuhnroyal deleted the update/example branch June 4, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants