refactor: enable and fix some lint rules #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josxha
changed the title
MapOptions.hash, change annotationOrder and annotationConsumeTapEvents to a Set
|
@kuhnroyal I reverted the breaking changes to make this pr code style only. Let me know if you disagree with any or the enabled lint rules. I'd appreciate a code review. (: Or would you prefer to have every rule split in separate pull requests? |
kuhnroyal
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I enabled a bunch of simple lint rules. All those lints in one pull request because it would have been a lot of really small pull requests otherwise. But I created for every lint one commit in case thats better to review.
This pull request introduces the following breaking changes:Remove the parameterhashfromMapOptionsbecause it was not used.The parameter type of
annotationOrderandannotationConsumeTapEventsfromMapLibreMaphas changed to a Set.