Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚚 restructure folders with basic melos #453

Merged
merged 41 commits into from
Jun 7, 2024

Conversation

XanderD99
Copy link
Contributor

move base project in seperate folder
prefix all folders with 'flutter_'
update folders where needed in code
update folders in .githubworkflows
add code-workspace file for those who want it 😄

XanderD99 added 3 commits June 7, 2024 08:59
move base project in seperate folder
prefix all folders with 'flutter_'
update folders where needed in code
update folders in .githubworkflows
add code-workspace file for those who want it 😄
@kuhnroyal
Copy link
Collaborator

Awesome, thanks!

prefix all folders with 'flutter_'

What is the motivation for this? I think it would be preferrable to use the package names.

@XanderD99
Copy link
Contributor Author

Just to have an additional clarification that this is a flutter implementation and not something else.

But if you prefer the package name as folder name it is a low effort to change it.

Copy link
Collaborator

@josxha josxha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing all the refactoring.
Could you check on my comments please?

.github/workflows/flutter_ci.yml Outdated Show resolved Hide resolved
.github/workflows/flutter_ci.yml Outdated Show resolved Hide resolved
.github/workflows/publish.yml Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
.gitignore Show resolved Hide resolved
flutter_maplibre_gl/LICENSE Outdated Show resolved Hide resolved
flutter_maplibre_gl/analysis_options.yaml Outdated Show resolved Hide resolved
flutter_maplibre_gl_platform_interface/pubspec.yaml Outdated Show resolved Hide resolved
melos.yaml Outdated Show resolved Hide resolved
pubspec.yaml Outdated Show resolved Hide resolved
@XanderD99
Copy link
Contributor Author

Took a moment but everything should be resolved except for renaming to maplibre_gl_workspace. bluefireteam/melos-action was complaining that it expected name to be maplibre_gl ¯_(ツ)_/¯

@josxha
Copy link
Collaborator

josxha commented Jun 7, 2024

Took a moment but everything should be resolved except for renaming to maplibre_gl_workspace.

The example app had the wrong path for maplibre_gl. Fixed it.

I'll do a rebase and add a CHANGELOG entry. 👍

XanderD99 added 5 commits June 7, 2024 15:35
move base project in seperate folder
prefix all folders with 'flutter_'
update folders where needed in code
update folders in .githubworkflows
add code-workspace file for those who want it 😄
@josxha
Copy link
Collaborator

josxha commented Jun 7, 2024

Oof, that was a rebase to remember🤯
I updated the flutter beta workflow to use melos, too. I think that should be all.👍

Copy link
Collaborator

@kuhnroyal kuhnroyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@josxha josxha merged commit 8e35f0a into maplibre:main Jun 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants