Run JS tests in Playwright Firefox alongside Chromium - #1380
Merged
Conversation
sargunv
temporarily deployed
to
cloudflare-pages
September 9, 2026 09:06 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
cursor
Bot
changed the title
The suite does not use the Chrome, Firefox, or Edge binaries on GitHub's Ubuntu image, and Safari is not available there. Print the Chromium version from test:js so CI logs identify the browser that actually ran. Co-authored-by: github.boned427 <github.boned427@passmail.net>
Install Firefox the same way as Chromium, point FIREFOX_BIN at it, and launch headed Firefox under Xvfb on Linux so MapLibre can get a WebGL context. Firefox headless still has no WebGL. Co-authored-by: github.boned427 <github.boned427@passmail.net>
useFirefox() pulls that Karma plugin; the lockfile has to list it. Co-authored-by: github.boned427 <github.boned427@passmail.net>
sargunv
force-pushed
the
cursor/js-test-browser-floor-easy-9425
branch
from
September 11, 2026 05:53
a4dc76b to
b2c66be
Compare
sargunv
marked this pull request as ready for review
September 11, 2026 06:39
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial work on #1169. This adds Firefox coverage; WebKit and a published browser floor are not part of this PR.
Description
mise run test:jsinstalls Playwright Firefox alongside Chromium and runs both JS test suites in each browser. Firefox is headless except on Linux, where headless Firefox has no WebGL, so the task runs it headed under Xvfb. The JS CI variant is renamed fromchromiumtochromium-firefox, and the antimeridian query test now settles before reading both world copies, which Firefox on Linux otherwise raced.Validation
mise run check,mise run ci:test-scripts, andmise run test:json macOS (631 cases each in ChromeHeadless 151 and Firefox 153, no Firefox window). The CI JS job passes the same suites on Linux under Xvfb.AI assistance
Cursor Grok 4.6 (Cloud Agent) for the initial draft; Claude Code (Fable 5.1) for the rebase, headless switch, and review fixes.